grpc-js: Fix interactions between proxy code and new URI parsing#1375
Merged
murgatroid99 merged 6 commits intogrpc:masterfrom Apr 21, 2020
Merged
Conversation
This was referenced Apr 21, 2020
nicolasnoble
approved these changes
Apr 21, 2020
|
It looks like like, that this fix do not really work. I get the following error message: |
Member
Author
|
@ThWoywod Can you run your code with the environment variables |
Member
Author
|
Never mind on the trace information. I believe I solved the problem in #1381. This time I managed to test it and I did successfully traverse a proxy and get a response from the server. |
|
Yeah thanks, with v 1.0.2 it works pretty well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were multiple issues here:
We expect a proxy URL in the form
http://host:port, but this does not actually fit with our naming scheme, so the URI parser parses it wrong. The solution is to revert to a previous version ofgetProxyInfothat parses the proxy address using theURLclass.If the target had no scheme and was parsed weirdly into the
GrpcUristructure, the resolver knew how to deal with that, but the proxy didn't, and it was making a bad request to the proxy. The solution is to stop using a default resolver, and instead modify the target at channel construction time so that it has a known scheme.The channel constructor was just overwriting the target after it got modified by the proxy.
The proxy map result target didn't have an explicit scheme, even though it would definitely need to be interpreted as a DNS name. Added a scheme to fix that.