grpc-js: Different handling for errors when starting streams#1251
Merged
murgatroid99 merged 2 commits intogrpc:masterfrom Feb 4, 2020
Merged
Conversation
nicolasnoble
reviewed
Feb 4, 2020
packages/grpc-js/src/channel.ts
Outdated
| Status.UNAVAILABLE, | ||
| 'Failed to start call on picked subchannel' | ||
| ); | ||
| /* An error here indicates thaat something when wrong with |
Member
Author
There was a problem hiding this comment.
Fixed it, plus two other errors in that comment.
nicolasnoble
approved these changes
Feb 4, 2020
Contributor
nicolasnoble
left a comment
There was a problem hiding this comment.
Typo - otherwise LGTM
Member
Author
|
Windows Node 12 failure: js client -> js server.client should not wait for ready by default. Expected UNAVAILABLE, got DEADLINE_EXCEEDED. Rerunning to check for consistency. This test does not use the server, so the server language should not matter, but the same test passed with js client -> native server. |
This was referenced Feb 20, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first few lines of this change are just formatting fixes. The relevant parts are the
tryPickchanges. This fixes #1250 (see my comment in the issue linked from that issue).