Update submodule, test --no-duplicate-basename-check option#1232
Update submodule, test --no-duplicate-basename-check option#1232murgatroid99 wants to merge 2 commits intogrpc:masterfrom
Conversation
| "electron-build": "node-pre-gyp configure build --runtime=electron --disturl=https://atom.io/download/atom-shell", | ||
| "coverage": "istanbul cover ./node_modules/.bin/_mocha test", | ||
| "install": "node-pre-gyp install --fallback-to-build --library=static_library", | ||
| "install": "node-pre-gyp install --fallback-to-build --library=static_library --no-duplicate-basename-check", |
There was a problem hiding this comment.
I think you need a -- before --no-duplicate-basename-check to pass it through to node-gyp.
e.g: "install": "node-pre-gyp install --fallback-to-build --library=static_library -- --no-duplicate-basename-check",
(this should let the build go farther but it seems like from the error text that the conflicting files might need to be renamed in the submodule?).
There was a problem hiding this comment.
I considered that but the error log contains this line:
gyp ERR! command "/home/kbuilder/.nvm/versions/node/v8.17.0/bin/node" "/home/kbuilder/.nvm/versions/node/v8.17.0/lib/node_modules/npm/node_modules/node-gyp/bin/node-gyp.js" "configure" "--fallback-to-build" "--library=static_library" "--no-duplicate-basename-check" "--module=/tmpfs/src/github/grpc-node/packages/grpc-native-core/src/node/extension_binary/node-v57-linux-x64-glibc/grpc_node.node" "--module_name=grpc_node" "--module_path=/tmpfs/src/github/grpc-node/packages/grpc-native-core/src/node/extension_binary/node-v57-linux-x64-glibc" "--napi_version=4" "--node_abi_napi=napi" "--napi_build_version=0" "--node_napi_label=node-v57"
which appears to indicate that that option was in fact passed to gyp though node-gyp.
There was a problem hiding this comment.
I have now tried this idea. It does not change the behavior, and it appears to remove that option from the logged node-gyp command line
There was a problem hiding this comment.
Oh that is odd, when I make this change locally and run npm install from within packages/grpc-native-core I get to a point where I see AssertionError: $(builddir)/base_dynamic_annotations.a != $(builddir)/libabsl/base_dynamic_annotations.a instead.
82993c1 to
4ca3be5
Compare
If the
node-gypinformation about that option is correct, the Mac build will fail because there are two files with the same name and libtool on Mac can't handle that.