Upgrade Android Gradle plugin to 7.4.0#9933
Merged
temawi merged 1 commit intogrpc:masterfrom Mar 8, 2023
Merged
Conversation
a747e88 to
50dc38c
Compare
This is the latest version of the plugin supported by the Gradle version in use at the moment (7.6). Note that this also upgrades the R8 optimizer to a version (4.0.48) that now uses "full mode" optimization by default. This also splits off Android projects to run under Java 11 (Gradle plugin requirement) while the other projects continue to run under Java 8.
50dc38c to
af47ff2
Compare
ejona86
approved these changes
Mar 8, 2023
YifeiZhuang
reviewed
Mar 10, 2023
| @@ -1,6 +1,5 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <manifest xmlns:android="http://schemas.android.com/apk/res/android" | |||
| package="io.grpc.binder"> | |||
Member
There was a problem hiding this comment.
so we have to remove the package because of the upgrade requires it?
it seems the missing package breaks the tests during import, e.g. https://fusion2.corp.google.com/presubmit/tap/515733025/OCL:515733025:BASE:515733282:1678485934756:15a4af1c/targets/invocations/38138659-39e8-43eb-8bd3-d1f8de15cb21/targets/%2F%2Fjavatests%2Fcom%2Fgoogle%2Fnet%2Fgrpc%2Fintegration%2Fhexa:grpc_android_19_x86_test_hexa_environment_smoke_test.lite/log
Contributor
Author
There was a problem hiding this comment.
Yes there was an error for having the package in the manifest. The new thing is to define it as the "namespace" in build.gradle.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the latest version of the plugin supported by the Gradle version
in use at the moment (7.6).
Note that this also upgrades the R8 optimizer to a version (4.0.48) that
now uses "full mode" optimization by default.
This also splits off Android projects to run under Java 11 (Gradle
plugin requirement) while the other projects continue to run under Java
8.