Revert "Fix for ipv6 link local with scope (#9326)" (1.48.x backport)#9376
Merged
ejona86 merged 1 commit intogrpc:v1.48.xfrom Jul 15, 2022
Merged
Conversation
This reverts commit c1abc7f. It produced compilation issues inside Google. I strongly suspect it isn't this commit or gRPC's fault, but it prevents further testing until it is resolved.
sergiitk
approved these changes
Jul 14, 2022
Contributor
|
@ejona86 was the issue related to this? If no, when the code will be put back for the 1.48.X? |
Member
Author
|
The issue was that HostAndPort and InetAddresses couldn't be found in a very specific compilation environment. That still needs to be resolved. |
Contributor
|
@ejona86 Thank you for sharing, do you think using the bytes constructor, the first solution, is an option? while the HostAndPort and InetAddresses are not fix. |
Contributor
|
@ejona86 Do you have any update on this? I'd like to stop using a fork version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit c1abc7f. It
produced compilation issues inside Google. I strongly suspect it isn't
this commit or gRPC's fault, but it prevents further testing until it is
resolved.
CC @jader-eero
Backport of #9375