Skip to content

googleapis: Stabilize google-c2p resolver#8970

Merged
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:stabilize-c2pnr
Aug 19, 2022
Merged

googleapis: Stabilize google-c2p resolver#8970
ejona86 merged 1 commit intogrpc:masterfrom
ejona86:stabilize-c2pnr

Conversation

@ejona86
Copy link
Copy Markdown
Member

@ejona86 ejona86 commented Mar 4, 2022

Preserve google-c2p-experimental support for the moment to ease testing
migration.

Preserve google-c2p-experimental support for the moment to ease testing
migration.
@ejona86 ejona86 requested a review from apolcyn March 4, 2022 20:51
@ejona86 ejona86 added TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved and removed TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved labels Mar 4, 2022
@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Mar 8, 2022

We've discovered some concerns with xDS+RLS that we want to address before stabilizing. The current handling of cluster_specifier would NACK for unimplemented/unknown fields, but grpc/proposal#292 would make the behavior nicer to future additions. But that can all happen for the next release.

Closing for now. I'll reopen when the XdsClient changes are in.

@ejona86 ejona86 closed this Mar 8, 2022
@ejona86 ejona86 reopened this Apr 4, 2022
@ejona86 ejona86 added the kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary label Apr 4, 2022
@grpc-kokoro grpc-kokoro removed kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Apr 4, 2022
@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Apr 4, 2022

#9014 had the necessary behavior changes for unknown cluster specifiers.

@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Apr 8, 2022

@apolcyn, how do we feel about this? The v1.46.x branch cut should have already happened at this point.

@ejona86 ejona86 added the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Apr 8, 2022
@ejona86 ejona86 removed the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Apr 25, 2022
@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Apr 25, 2022

This should be fixed to our knowledge in v1.46.x, but it isn't entirely essential that it is stabilized in v1.46.x and the severity of the recent issues reduce our confidence such that we don't want to stabilize in v1.46.

@ejona86 ejona86 added the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Aug 16, 2022
@ejona86
Copy link
Copy Markdown
Member Author

ejona86 commented Aug 16, 2022

@apolcyn, do you want to approve this now?

Copy link
Copy Markdown
Contributor

@apolcyn apolcyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (saw #9459 went in)

@ejona86 ejona86 requested a review from temawi August 19, 2022 19:47
@ejona86 ejona86 merged commit 2a36483 into grpc:master Aug 19, 2022
@ejona86 ejona86 deleted the stabilize-c2pnr branch August 19, 2022 20:38
@ejona86 ejona86 removed the TODO:release blocker Issue/PR is important enough to delay the release. Removed after release issues resolved label Aug 22, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants