Emulate AbstractManagedChannelImplBuilder maxInboundMessageSize(int)#8597
Closed
ejona86 wants to merge 1 commit intogrpc:masterfrom
Closed
Emulate AbstractManagedChannelImplBuilder maxInboundMessageSize(int)#8597ejona86 wants to merge 1 commit intogrpc:masterfrom
ejona86 wants to merge 1 commit intogrpc:masterfrom
Conversation
In dbd903c we started generatating AbstractManagedChannelImplBuilder methods in a way that they are present for ABI but on recompilation only public ManagedChannelBuilder-returning methods would be used. However, this sorta missed maxInboundMessageSize which is now being handled by the concrete classes (e.g, NettyChannelBuilder) instead of ManagedChannelImplBuilder. Users on the old ABI will end up getting ManagedChannelImplBuilder.maxInboundMessageSize() which does nothing. So, let's just implement the method and have it jump back up to the concrete class. Hacky, but easy and predictable and will go away once we remove the rest of the AbstractManagedChannelImplBuilder compatibility hacks. Fixes grpc#8313
Member
Author
|
Closing in favor of #8607 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In dbd903c we started generatating AbstractManagedChannelImplBuilder
methods in a way that they are present for ABI but on recompilation only
public ManagedChannelBuilder-returning methods would be used. However,
this sorta missed maxInboundMessageSize which is now being handled by
the concrete classes (e.g, NettyChannelBuilder) instead of
ManagedChannelImplBuilder. Users on the old ABI will end up getting
ManagedChannelImplBuilder.maxInboundMessageSize() which does nothing.
So, let's just implement the method and have it jump back up to the
concrete class. Hacky, but easy and predictable and will go away once we
remove the rest of the AbstractManagedChannelImplBuilder compatibility
hacks.
Fixes #8313