Skip to content

core: Inline AbstractServerImplBuilder#7432

Merged
sergiitk merged 3 commits intogrpc:masterfrom
sergiitk:remove-abstract-server-builder
Sep 18, 2020
Merged

core: Inline AbstractServerImplBuilder#7432
sergiitk merged 3 commits intogrpc:masterfrom
sergiitk:remove-abstract-server-builder

Conversation

@sergiitk
Copy link
Member

@sergiitk sergiitk commented Sep 16, 2020 •
edited
Loading

A part of #7211.

Note to reviewers

Compare AbstractServerImplBuilder in ServerImplBuilder:

git diff f04f33efe:core/src/main/java/io/grpc/internal/AbstractServerImplBuilder.java 98a944d:core/src/main/java/io/grpc/internal/ServerImplBuilder.java

Compare AbstractServerImplBuilderTest in ServerImplBuilderTest:

git diff f04f33efe:core/src/test/java/io/grpc/internal/AbstractServerImplBuilderTest.java 98a944d:core/src/test/java/io/grpc/internal/ServerImplBuilderTest.java

@sergiitk sergiitk marked this pull request as ready for review September 16, 2020 20:56
@sergiitk sergiitk requested a review from ejona86 September 16, 2020 20:56
ejona86
ejona86 approved these changes Sep 17, 2020
View reviewed changes
@sergiitk sergiitk merged commit b571f23 into grpc:master Sep 18, 2020
@sergiitk sergiitk deleted the remove-abstract-server-builder branch September 18, 2020 20:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sergiitk @ejona86