Channel builders extend public API#7359
Merged
sergiitk merged 6 commits intogrpc:masterfrom Sep 2, 2020
Merged
Conversation
sergiitk
commented
Aug 25, 2020
ejona86
approved these changes
Sep 1, 2020
Member
ejona86
left a comment
There was a problem hiding this comment.
All minor stuff except for the TestServiceClient comment, but that one is easy.
core/src/main/java/io/grpc/inprocess/InProcessChannelBuilder.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/grpc/internal/ManagedChannelImplTest.java
Outdated
Show resolved
Hide resolved
core/src/main/java/io/grpc/internal/ManagedChannelImplBuilder.java
Outdated
Show resolved
Hide resolved
core/src/test/java/io/grpc/internal/ServiceConfigErrorHandlingTest.java
Outdated
Show resolved
Hide resolved
interop-testing/src/main/java/io/grpc/testing/integration/TestServiceClient.java
Outdated
Show resolved
Hide resolved
c50d3e6 to
9cd0e1a
Compare
8f68dba to
b2365a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first part of #7211: Hide
AbstractManagedChannelImplBuilderfrom public API.