bazel: Add comment for public protoc plugin#5952
Merged
ejona86 merged 1 commit intogrpc:masterfrom Jul 3, 2019
Merged
Conversation
Contributor
|
There was already a PR for this, #5947. The only difference is comment. |
Member
Author
|
Hmm... Well, the comment is important. We could merge the other one and then this one could just become the comment. Or the other changes to include some comment of some sort. |
dapengzhang0
approved these changes
Jul 3, 2019
Contributor
Agree on this. |
0e39359 to
00873e7
Compare
Member
Author
|
Converted this PR to just a comment, to be merged after #5947 |
dapengzhang0
approved these changes
Jul 3, 2019
This was referenced Jul 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 3rd-party rules_proto project is referencing our compiler directly
and not using our java_grpc_library. This target is fine for them to
use (although we'd prefer using our java_grpc_library), but most users
shouldn't be touching it.
Related to #5942 and #5947