netty: refine filtering for benign transport level exceptions#5873
Merged
carl-mastrangelo merged 1 commit intogrpc:masterfrom Jun 13, 2019
Merged
netty: refine filtering for benign transport level exceptions#5873carl-mastrangelo merged 1 commit intogrpc:masterfrom
carl-mastrangelo merged 1 commit intogrpc:masterfrom
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Contributor
Author
|
I signed it. |
Transport level exceptions (e.g. "Connection reset by peer") are not useful and clutter the logs. `NettyServerTransport` contains logic to log such exceptions at level `FINE`. When running with epoll, transport level exceptions are prefixed with additional contextual information (e.g. "syscall:read(..) failed:") that causes the exceptions to be logged at level `INFO`. Update the filtering logic to match on error messages _containing_ the blacklisted messages, rather than using string equality. Closes grpc#5872. Signed-off-by: Nick Travers <n.e.travers@gmail.com>
1414388 to
06e2a5c
Compare
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
zhangkun83
approved these changes
Jun 12, 2019
Contributor
|
@ejona86, looks like the CLA bot isn't working correctly. |
Contributor
Author
|
I signed it. |
Contributor
|
@nicktrav merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Transport level exceptions (e.g. "Connection reset by peer") are not
useful and clutter the logs.
NettyServerTransportcontains logic tolog such exceptions at level
FINE.When running with epoll, transport level exceptions are prefixed with
additional contextual information (e.g. "syscall:read(..) failed:") that
causes the exceptions to be logged at level
INFO.Update the filtering logic to match on error messages containing the
blacklisted messages, rather than using string equality.
Closes #5872.
Signed-off-by: Nick Travers n.e.travers@gmail.com