xds: implement lb policy backend metric api#5639
Merged
voidzcy merged 32 commits intogrpc:masterfrom May 24, 2019
Merged
Conversation
a26bf96 to
420a6df
Compare
voidzcy
commented
Apr 25, 2019
420a6df to
b92463e
Compare
13911a3 to
f07391a
Compare
3351346 to
4b238ea
Compare
zhangkun83
reviewed
Apr 25, 2019
642cdae to
742faf7
Compare
zhangkun83
reviewed
May 5, 2019
Codecov Report
@@ Coverage Diff @@
## master #5639 +/- ##
============================================
- Coverage 82.38% 82.36% -0.03%
+ Complexity 3207 3203 -4
============================================
Files 265 265
Lines 17031 17031
Branches 2001 2001
============================================
- Hits 14031 14027 -4
- Misses 2209 2210 +1
- Partials 791 794 +3
Continue to review full report at Codecov.
|
ddf3caa to
66e5545
Compare
46d2697 to
cdaea7a
Compare
zhangkun83
reviewed
May 22, 2019
Contributor
zhangkun83
left a comment
There was a problem hiding this comment.
Nicely written! Some minor comments.
… OrcaReportListener installed for retrieving per-request ORCA data
…most helper in the wrapping structure
…or per-request and out-of-band cases
…et rid of static methods for easier user testing
…rresponding OrcaOobReportListener registered are passed to the listener callback
…ow ties with Subchannel)
32d97e8 to
2f9f6bb
Compare
zhangkun83
approved these changes
May 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Implemented two utility classes for clients to access ORCA backend metric.
OrcaPerRequestUtilprovides methods to interceptClientStreamTracer.Factorywith a listener registered to receive per-request ORCA reports.OrcaOobUtilprovides methods to interceptLoadBalancer.Helperwith a listener registered to receive out-of-band ORCA reports.Internal design doc is at
go/grpc-lb-policy-backend-metric-api-java