core: deprecate LoadBalancer.Helper#getNameResolverFactory#5418
Merged
zhangkun83 merged 1 commit intogrpc:masterfrom Mar 4, 2019
Merged
core: deprecate LoadBalancer.Helper#getNameResolverFactory#5418zhangkun83 merged 1 commit intogrpc:masterfrom
zhangkun83 merged 1 commit intogrpc:masterfrom
Conversation
This was added for the potential use case of needing to resolve target names (of the same scheme as the top-level channel's target's) in the LoadBalancer. Now actual use cases come up in xDS that we need to resolve fully-qualified target strings with arbitrary schemes. This method has never been used and won't fit future uses because it's too restrictive.
ejona86
approved these changes
Mar 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was added for the potential use case of needing to resolve target
names (of the same scheme as the top-level channel's target's) in the
LoadBalancer. Now actual use cases come up in xDS that we need to
resolve fully-qualified target strings with arbitrary schemes. This
method has never been used and won't fit future uses because it's too
restrictive.