netty: add handler to combine small writes into larger buffer#2146
Closed
buchgr wants to merge 2 commits intogrpc:masterfrom
Closed
netty: add handler to combine small writes into larger buffer#2146buchgr wants to merge 2 commits intogrpc:masterfrom
buchgr wants to merge 2 commits intogrpc:masterfrom
Conversation
e623af1 to
180d393
Compare
It's not safe to use an ArgumentCaptor to capture a ByteBuf, as by the time the buffer is accessed it may already have been released.
180d393 to
3c8404c
Compare
3c8404c to
cff32ee
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
benchmarks coming ...