Skip to content

xds, rls: Experimental metrics are disabled by default (v1.64.x backport)#11197

Merged
DNVindhya merged 1 commit into
grpc:v1.64.xfrom
DNVindhya:backport-1.64-wrr-rls-experimental-metrics
May 13, 2024
Merged

xds, rls: Experimental metrics are disabled by default (v1.64.x backport)#11197
DNVindhya merged 1 commit into
grpc:v1.64.xfrom
DNVindhya:backport-1.64-wrr-rls-experimental-metrics

Conversation

@DNVindhya

Copy link
Copy Markdown
Contributor

This PR

  • Updates WRR and RLS metrics to be experimental and therefore disabled by default.

    From gRFC A78:

    Metric Stability

    All metrics added in this proposal will start as experimental and therefore off by default.

  • Adds "Experimental." in the beginning of metric description.

  • Updates metric units to include {}, as strings inside {} are suffixed to metric name in some metric conversions.

Backport of #11196

Experimental metrics (i.e WRR and RLS metrics) are disabled by default. Users are expected to explicitly enable while configuring metrics.
@DNVindhya DNVindhya requested a review from ejona86 May 11, 2024 01:18
@DNVindhya DNVindhya merged commit 80f872e into grpc:v1.64.x May 13, 2024
@DNVindhya DNVindhya deleted the backport-1.64-wrr-rls-experimental-metrics branch May 13, 2024 16:04
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants