Skip to content

cronet : Update library + Move to StableAPIs in Cronet#11068

Merged
temawi merged 4 commits intogrpc:masterfrom
Ashok-Varma:update_cronet
Apr 22, 2024
Merged

cronet : Update library + Move to StableAPIs in Cronet#11068
temawi merged 4 commits intogrpc:masterfrom
Ashok-Varma:update_cronet

Conversation

@Ashok-Varma
Copy link
Contributor

@Ashok-Varma Ashok-Varma commented Apr 3, 2024 •
edited
Loading

In this Pull Request

  1. Cronet is updated to 119.6045.31 from 108.5359.79, In which Experimental API's are deprecated and moved to Stable Interfaces.
  2. grpc-cronet Moved Experimental API's to Stable Interfaces
  3. Removed use of reflection as Experimental API's are no longer in use (which are introdced in cronet: use reflection to load and invoke experimental APIs in ExperimentalBidirectionalStream.Builder #6111)

Minor Changes

  1. Updated JavaDoc : Android Permission from MODIFY_NETWORK_ACCOUNTING (deprecated) to UPDATE_DEVICE_STATS
  2. Update to JAVA-8 API's to improve code readability
  3. Moved from Charset.forName("UTF-8") to StandardCharsets.UTF_8 Standard

Fixes #10396 (@sergiitk)

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 3, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@Ashok-Varma Ashok-Varma changed the title Update Cronet to latest release. Move Away from ExperimentalAPIs in cronet Update Cronet to latest release. Move to StableAPIs in cronet Apr 3, 2024
@Ashok-Varma Ashok-Varma changed the title Update Cronet to latest release. Move to StableAPIs in cronet cronet : Update library. Move to StableAPIs in Cronet Apr 3, 2024
@Ashok-Varma Ashok-Varma changed the title cronet : Update library. Move to StableAPIs in Cronet cronet : Update library + Move to StableAPIs in Cronet Apr 3, 2024
@sergiitk sergiitk requested review from ejona86 and temawi April 4, 2024 21:07
@sergiitk sergiitk added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 4, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 4, 2024
@Ashok-Varma
Copy link
Contributor Author

Ashok-Varma commented Apr 9, 2024

Hi @sergiitk / @ejona86 / @temawi,

I've updated changes in to different commits. It's open for review

@Ashok-Varma
Copy link
Contributor Author

Ashok-Varma commented Apr 17, 2024 •
edited
Loading

Hi @sergiitk,

I was just wondering on Linux and Macos artifacts taking time (those are stalled for ~10 days), does it signify any problem in the builds ? or are we supposed to generate and add them ?

ejona86
ejona86 reviewed Apr 17, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, but I'm not sure if enough Android devices have the stable API. We may need to fall-back to the experimental API to reach more devices. @temawi, would you be able to investigate that?

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 17, 2024
@ejona86
Copy link
Member

ejona86 commented Apr 17, 2024

I was just wondering on Linux and Macos artifacts taking time (those are stalled for ~10 days), does it signify any problem in the builds ?

It's not a problem. We have to manually start those builds by adding that kokoro label.

@grpc-kokoro grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run labels Apr 17, 2024
@Ashok-Varma
Copy link
Contributor Author

Ashok-Varma commented Apr 18, 2024

This looks fine to me, but I'm not sure if enough Android devices have the stable API. We may need to fall-back to the experimental API to reach more devices. @temawi, would you be able to investigate that?

I agree to this, Adding little-bit of background :

  • ExperimentalAPI deprecation done on Oct 27, 2022
  • Any Custom Implementation of Cronet (if API is not yet updated), Needs to update the API +move the experimental implementations to CronetEngine.
  • All Googles cronet implementations (embedded, fallback, play-services) are compatible with new API.

@Ashok-Varma Ashok-Varma requested a review from ejona86 April 18, 2024 20:05
@temawi
Copy link
Contributor

temawi commented Apr 19, 2024

This looks fine to me, but I'm not sure if enough Android devices have the stable API. We may need to fall-back to the experimental API to reach more devices. @temawi, would you be able to investigate that?

I agree to this, Adding little-bit of background :

  • ExperimentalAPI deprecation done on Oct 27, 2022
  • Any Custom Implementation of Cronet (if API is not yet updated), Needs to update the API +move the experimental implementations to CronetEngine.
  • All Googles cronet implementations (embedded, fallback, play-services) are compatible with new API.

I also checked with the Cronet team - this should be a safe change to make.

ejona86
ejona86 approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@ejona86 ejona86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@temawi, given the commits are split out, we'll probably want to rebase this instead of squashing (ideally the commits would have cronet: prefixes to make scanning easier, but this is fine).

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 19, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 19, 2024
@Ashok-Varma
Copy link
Contributor Author

Ashok-Varma commented Apr 20, 2024 •
edited
Loading

@temawi, given the commits are split out, we'll probably want to rebase this instead of squashing (ideally the commits would have cronet: prefixes to make scanning easier, but this is fine).

Updated commits with cronet: prefix

@ejona86 ejona86 added the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 22, 2024
@grpc-kokoro grpc-kokoro removed the kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run label Apr 22, 2024
@temawi temawi added kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Apr 22, 2024
@grpc-kokoro grpc-kokoro removed kokoro:run Add this label to a PR to tell Kokoro the code is safe and tests can be run kokoro:force-run Add this label to a PR to tell Kokoro to re-run all tests. Not generally necessary labels Apr 22, 2024
@temawi temawi merged commit 77e59b2 into grpc:master Apr 22, 2024
@Ashok-Varma Ashok-Varma deleted the update_cronet branch April 23, 2024 16:18
@Ashok-Varma
Copy link
Contributor Author

Ashok-Varma commented Apr 24, 2024

Thank you @temawi and @ejona86 for the help on PR.
Any plans on next release date, What's the release cadence for gRPC ?

@ejona86
Copy link
Member

ejona86 commented Apr 24, 2024

@Ashok-Varma, see the milestones. Minor releases are scheduled every six weeks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejona86 ejona86 ejona86 approved these changes

@temawi temawi Awaiting requested review from temawi

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

grpc-cronet: ExperimentalBidirectionalStream, ExperimentalCronetEngine are deprecated

5 participants

@Ashok-Varma @ejona86 @temawi @sergiitk @grpc-kokoro