CheckedForwardingClientCall should pass trailers from the caught exception#10356
Merged
temawi merged 3 commits intogrpc:masterfrom Jul 10, 2023
yamasa:master
Merged
CheckedForwardingClientCall should pass trailers from the caught exception#10356temawi merged 3 commits intogrpc:masterfrom yamasa:master
temawi merged 3 commits intogrpc:masterfrom
yamasa:master
Conversation
…ption `StatusException` thrown from `checkedStart()` may have `trailers`. Therefore, `CheckedForwardingClientCall` should pass the `trailers` to `responseListener.onClose()`.
ejona86
approved these changes
Jul 7, 2023
Member
ejona86
left a comment
There was a problem hiding this comment.
Note that this is changing a stable API. But it seems fair.
temawi
approved these changes
Jul 7, 2023
Comment on lines
+240
to
+241
| Metadata trailers = trailersFromThrowable != null ? trailersFromThrowable : new Metadata(); | ||
| responseListener.onClose(Status.fromThrowable(e), trailers); |
Contributor
There was a problem hiding this comment.
You could inline trailers, but I don't have strong feelings about it.
Suggested change
| Metadata trailers = trailersFromThrowable != null ? trailersFromThrowable : new Metadata(); | |
| responseListener.onClose(Status.fromThrowable(e), trailers); | |
| responseListener.onClose(Status.fromThrowable(e), trailersFromThrowable != null ? trailersFromThrowable : new Metadata()); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StatusExceptionthrown fromcheckedStart()may havetrailers. Therefore,CheckedForwardingClientCallshould pass thetrailerstoresponseListener.onClose().