Sort the policies in a rule by policy name when parsing from proto.#10334
Merged
larry-safran merged 6 commits intogrpc:masterfrom Jul 10, 2023
Merged
Sort the policies in a rule by policy name when parsing from proto.#10334larry-safran merged 6 commits intogrpc:masterfrom
larry-safran merged 6 commits intogrpc:masterfrom
Conversation
…his fixes the server sending a GOAWAY when an LDS update with no changes other than ordering is received.
YifeiZhuang
approved these changes
Jul 7, 2023
| + "cyMatcher{name\\u003dpsm-interop-authz-policy-20230514-0917-er2uh_td_rbac_rule_"; | ||
|
|
||
| for (Integer id : ids) { | ||
| // Policy policy = Policy.newBuilder().setCondition(Expr.newBuilder() |
| Any proto = Any.pack(rbacPerRoute); | ||
| return new RbacFilter().parseFilterConfigOverride(proto); | ||
| } | ||
|
|
Cleanup per reviewer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the server sending a GOAWAY when an LDS update with no changes other than ordering is received.
Fixes b/285622042