Skip to content

Add support for Guava 27.0.1 #5214

@pgr0ss

Description

@pgr0ss

What version of gRPC are you using?

1.16.0 and 1.17.2

What did you expect to see?

I tried to upgrade guava from 26.0-jre to 27.0.1-jre and I get compilation errors in my project (using bazel):

ERROR: /home/admin/.cache/bazel/_bazel_admin/b812dc62599757b102340939b9116fb8/external/io_grpc_grpc_java/stub/BUILD.bazel:1:1: Building external/io_grpc_grpc_java/stub/libstub.jar (12 source files) failed (Exit 1)                                                                                                                                                                                                                    
external/io_grpc_grpc_java/stub/src/main/java/io/grpc/stub/ClientCalls.java:487: error: cannot access InternalFutureFailureAccess                                                               
  private static final class GrpcFuture<RespT> extends AbstractFuture<RespT> {                                                                                 
                       ^                                                                                                                                                                                                                                                                                                                                                                                                                 
  class file for com.google.common.util.concurrent.internal.InternalFutureFailureAccess not found 

It seems like they pulled this out into the failureaccess library. If I add "@com_google_guava_failureaccess//jar", to the list of deps, it seems to work:

deps = [
"//context",
"//core",
"@com_google_code_findbugs_jsr305//jar",
"@com_google_guava_guava//jar",
"@com_google_j2objc_j2objc_annotations//jar",
],

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions