Cherry-pick #9081 into v1.81.x#9102
Merged
Merged
Conversation
…grpc#9081) Fixes grpc#9053 Client and Server metrics and traces handling code during RPC was using the same RPCInfo. This lead to overwriting of context when an application was acting as server and then initiating other grpc call as a client. This PR segregates the rpcInfoKey context key into clientRPCInfoKey and serverRPCInfoKey so that it is not reused/overwritten between server and client code. RELEASE NOTES: * otel: Segregate client and server RPCInfo used for metrics and traces.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v1.81.x #9102 +/- ##
===========================================
- Coverage 82.56% 82.29% -0.27%
===========================================
Files 413 413
Lines 33475 33507 +32
===========================================
- Hits 27637 27576 -61
- Misses 4259 4286 +27
- Partials 1579 1645 +66
🚀 New features to boost your workflow:
|
Contributor
|
We should hold off until we release 1.81.0 since we haven't tested this change in google3 yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #9081
RELEASE NOTES: