xds: Add cluster endpoint watchers to depndency manager#8744
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8744 +/- ##
==========================================
- Coverage 83.39% 83.34% -0.05%
==========================================
Files 419 418 -1
Lines 32566 32897 +331
==========================================
+ Hits 27159 27419 +260
- Misses 4023 4084 +61
- Partials 1384 1394 +10
🚀 New features to boost your workflow:
|
easwars
reviewed
Dec 9, 2025
easwars
reviewed
Dec 9, 2025
easwars
reviewed
Dec 11, 2025
easwars
reviewed
Dec 11, 2025
easwars
reviewed
Dec 11, 2025
Contributor
|
Can you also please check the codecov report here: #8744 (comment) to see if there are any valid lines that are missing test coverage. Thanks. |
easwars
reviewed
Dec 11, 2025
easwars
reviewed
Dec 16, 2025
Comment on lines
+204
to
+216
| {ID: clients.Locality{ | ||
| Region: "region-1", | ||
| Zone: "zone-1", | ||
| SubZone: "subzone-1", | ||
| }, | ||
| Endpoints: []xdsresource.Endpoint{ | ||
| { | ||
| Addresses: []string{addr}, | ||
| HealthStatus: xdsresource.EndpointHealthStatusUnknown, | ||
| Weight: 1, | ||
| }, | ||
| }, | ||
| Weight: 1}, |
Contributor
There was a problem hiding this comment.
Doesn't seem to be fixed yet.
Comment on lines
+727
to
+739
| {ID: clients.Locality{ | ||
| Region: "region-1", | ||
| Zone: "zone-1", | ||
| SubZone: "subzone-1", | ||
| }, | ||
| Endpoints: []xdsresource.Endpoint{ | ||
| { | ||
| Addresses: []string{"localhost:8081"}, | ||
| HealthStatus: xdsresource.EndpointHealthStatusUnknown, | ||
| Weight: 1, | ||
| }, | ||
| }, | ||
| Weight: 1}, |
Contributor
|
I made a small refactoring commit to split the I also added the |
easwars
reviewed
Dec 18, 2025
easwars
left a comment
Contributor
There was a problem hiding this comment.
Some of my comments might be outdated as this point, as I pushed a couple of commits for more generics and some simplification around the dns resolver.
easwars
reviewed
Dec 18, 2025
easwars
approved these changes
Dec 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of A74 implementation which add CDS/EDS/DNS watchers to the dependency manager. It also adds a temporary flag that is disabled by default so that it is not used in the current RPC paths , but enabled in the dependency manager tests.
RELEASE NOTES: None