Skip to content

transport: Set buffer pool in tests#8688

Merged
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:set-buffer-pool-in-tests
Nov 4, 2025
Merged

transport: Set buffer pool in tests#8688
arjan-bal merged 1 commit into
grpc:masterfrom
arjan-bal:set-buffer-pool-in-tests

Conversation

@arjan-bal

Copy link
Copy Markdown
Contributor

This PR correctly sets the buffer pool for test clients and servers not created through the public gRPC API. This allows non-test code to assume the buffer pool is always present.

RELEASE NOTES: N/A

@arjan-bal arjan-bal added Type: Internal Cleanup Refactors, etc Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. labels Oct 31, 2025
@arjan-bal arjan-bal added this to the 1.78 Release milestone Oct 31, 2025
@codecov

codecov Bot commented Oct 31, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.24%. Comparing base (363018c) to head (3291713).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8688      +/-   ##
==========================================
- Coverage   83.43%   83.24%   -0.20%     
==========================================
  Files         415      415              
  Lines       32195    32197       +2     
==========================================
- Hits        26863    26803      -60     
- Misses       3980     4007      +27     
- Partials     1352     1387      +35     
Files with missing lines Coverage Δ
internal/transport/http_util.go 85.66% <ø> (-8.42%) ⬇️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arjan-bal arjan-bal requested review from dfawley, easwars and eshitachandwani and removed request for dfawley October 31, 2025 08:23
@easwars easwars assigned arjan-bal and unassigned easwars Nov 3, 2025
@arjan-bal arjan-bal merged commit 7472d57 into grpc:master Nov 4, 2025
14 of 17 checks passed
@arjan-bal arjan-bal deleted the set-buffer-pool-in-tests branch November 4, 2025 06:11
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Area: Transport Includes HTTP/2 client/server and HTTP server handler transports and advanced transport features. Type: Internal Cleanup Refactors, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants