client: remove trailing null from unix abstract socket address#5678
Merged
dfawley merged 1 commit intogrpc:masterfrom Sep 30, 2022
Merged
client: remove trailing null from unix abstract socket address#5678dfawley merged 1 commit intogrpc:masterfrom
dfawley merged 1 commit intogrpc:masterfrom
Conversation
|
|
Trailing nul byte is added by golang Dial wrapper. To avoid that one should use '@socket' as address instead of '\0socket' (see [1]). This change makes go-grpc behave like grpc/grpc (see [2]), making connecting to golang server with grpc_cli possible. [1]: https://go.googlesource.com/sys/+/master/unix/syscall_linux.go#420 [2]: https://github.com/grpc/grpc/blob/d43511f4af992862ae17c6fce5caa3ab3ce60995/src/core/lib/address_utils/parse_address.cc#L109
f740129 to
82ecdf8
Compare
dfawley
approved these changes
Sep 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trailing nul byte is added by golang Dial wrapper. To avoid that one should use '@socket' as address instead of '\0socket' (see 1).
This change makes go-grpc behave like grpc/grpc (see 2), making connecting to golang server with grpc_cli possible.
RELEASE NOTES: