internal/transport: remove duplicate code handling ctx errors#5112
Closed
andreimatei wants to merge 2 commits intogrpc:masterfrom
Closed
internal/transport: remove duplicate code handling ctx errors#5112andreimatei wants to merge 2 commits intogrpc:masterfrom
andreimatei wants to merge 2 commits intogrpc:masterfrom
Conversation
transport.ContextErr() was very similar to status.FromContextError(). Besides the code duplication, the latter is arguably better because it handles errors wrapping context errors, and the former only supports raw context errors. This patch does away with transport.ContextErr().
pickerWrapper had logic very similar to status.FromContextError() for transforming Context errors to status errors. This patch removes the duplication by delegating to the status library. Besides removing the code duplication, the status library is arguably more robust because it doesn't rely on ctx.Error() to only ever return two types of errors. I believe this patch and the previous one stand on their own, but, FWIW, they're also motivating by me wanting to experiment in the CockroachDB codebase with using a custom implementation of context.Context whose Err() method can return better errors than the stdlib context.Context. These errors would still wrap context.Canceled. Such an implementation would technically break the documentation of context.Context, which seems to exhaustively list the sentinel error that context.Context can return. Still, as grpc#4977 showed, most code should support wrapped context errors. This patch moves from "most code" to "all code" in gRPC. I haven't checked which of the callsites I've touched use contexts that might be inherited from a gRPC client, as opposed to contexts derived inside gRPC from context.Background (which contexts would not be affected by whatever I do outside of gRPC), but unifying all the context error handling code seems like a good idea to me universally.
zasweq
reviewed
Jan 19, 2022
Contributor
zasweq
left a comment
There was a problem hiding this comment.
Hello, this is an API change, and is externally facing and exported. Adding a parameter is not backwards compatible, and so unfortunately we cannot take this change. Feel free to make try and API change in internal/
Author
|
Would you take everything except the change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See individual commits.
RELEASE NOTES: none