docs: clarify "deprecated" to indicate whether some features may be removed in 1.x#2900
Merged
dfawley merged 3 commits intogrpc:masterfrom Jul 11, 2019
Merged
docs: clarify "deprecated" to indicate whether some features may be removed in 1.x#2900dfawley merged 3 commits intogrpc:masterfrom
dfawley merged 3 commits intogrpc:masterfrom
Conversation
… removed or not based on whether they were marked experimental as of v1.0/GA.
menghanl
reviewed
Jul 10, 2019
dialoptions.go
Outdated
| // https://github.com/grpc/grpc/blob/master/doc/service_config.md | ||
| // | ||
| // Deprecated: service config should be received through name resolver, as | ||
| // specified here. Will be removed in a future 1.x release. |
menghanl
approved these changes
Jul 10, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also, deprecate WithBalancerName (was experimental).
The decision of whether something may be removed is based on if it was marked experimental as of v1.0/GA or upon its introduction, in accordance with https://github.com/grpc/grpc-go/blob/master/Documentation/versioning.md.