xds: bazel proto gen code generation scripts#2775
Merged
lyuxuan merged 8 commits intogrpc:masterfrom Jun 27, 2019
Merged
Conversation
menghanl
reviewed
Apr 19, 2019
dfawley
reviewed
Apr 22, 2019
menghanl
reviewed
May 7, 2019
6830e36 to
bfc8df0
Compare
dfawley
approved these changes
Jun 21, 2019
Member
dfawley
left a comment
There was a problem hiding this comment.
Looks good - just a few bash quoting things.
| bazel build "$i" | ||
| done | ||
|
|
||
| cwd=$(pwd) |
Member
There was a problem hiding this comment.
This would need quotes, but you can use $PWD directly and delete this line.
| done | ||
|
|
||
| cwd=$(pwd) | ||
| dest=$cwd/../../proto/ |
Member
There was a problem hiding this comment.
Needs quotes in case the current directory has spaces.
| eval "$src" | | ||
| while IFS= read -r -d '' origin | ||
| do | ||
| target=${origin##*proto/} |
Member
There was a problem hiding this comment.
Not sure if quotes are needed here, but can't hurt
| while IFS= read -r -d '' origin | ||
| do | ||
| target=${origin##*proto/} | ||
| final=$dest$target |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.