client: fix handling of GRPC_GO_REQUIRE_HANDSHAKE=on to not interpret as "hybrid"#2603
Merged
dfawley merged 1 commit intogrpc:masterfrom Jan 29, 2019
dntj:master
Merged
client: fix handling of GRPC_GO_REQUIRE_HANDSHAKE=on to not interpret as "hybrid"#2603dfawley merged 1 commit intogrpc:masterfrom dntj:master
dfawley merged 1 commit intogrpc:masterfrom
dntj:master
Conversation
6cc789b made `envconfig.RequireHandshakeOn` the default when unspecified by environment variable, but missed a fallthrough leading to `GRPC_GO_REQUIRE_HANDSHAKE=on` specifying `envconfig.RequireHandshakeHybrid`.
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
on.
dfawley
approved these changes
Jan 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
6cc789b made
envconfig.RequireHandshakeOnthe default when unspecified by environment variable, but missed a fallthrough leading toGRPC_GO_REQUIRE_HANDSHAKE=onspecifyingenvconfig.RequireHandshakeHybrid. This change adds the missing fallthrough.