Add dial option to set balancer#1697
Merged
menghanl merged 3 commits intogrpc:masterfrom Dec 18, 2017
Merged
Conversation
dfawley
reviewed
Dec 1, 2017
Member
dfawley
left a comment
There was a problem hiding this comment.
Since we're giving users a way of specifying balancers by name, we should also provide a way of doing this programmatically vs. manually using strings.
I.e. we should add roundrobin.Name and grpc.PickFirstBalancerName constants.
| // WithBalancer returns a DialOption which sets a load balancer with the v1 API. | ||
| // Name resolver will be ignored if this DialOption is specified. | ||
| // Deprecated: use the new balancer APIs in balancer package instead. | ||
| // Deprecated: use the new balancer APIs in balancer package and WithBalancerName. |
Member
There was a problem hiding this comment.
Nit: add a blank comment line above this one so it's its own paragraph.
clientconn.go
Outdated
| } | ||
|
|
||
| // WithBalancerName sets the balancer that the ClientConn will be initialized | ||
| // with. The balancer can not be overridden by balancer option specified by |
Member
There was a problem hiding this comment.
Nit: "cannot" or "will not".
Also, maybe something like: "Balancers are registered by name using the balancer package" before this sentence?
0480a85 to
f379b65
Compare
menghanl
commented
Dec 1, 2017
Contributor
Author
menghanl
left a comment
There was a problem hiding this comment.
Thanks for the review. All done. PTAL.
dfawley
reviewed
Dec 4, 2017
clientconn.go
Outdated
| // withBalancerBuilder is for testing only. Users using custom balancers should | ||
| // register their balancer and use service config to choose the balancer to use. | ||
| func WithBalancerBuilder(b balancer.Builder) DialOption { | ||
| func withBalancerBuilder(b balancer.Builder) DialOption { |
dfawley
approved these changes
Dec 4, 2017
a04906e to
c24621d
Compare
|
Is this getting merged? I could use this feature.. |
1b7bf44 to
bedcbb9
Compare
menghanl
commented
Dec 12, 2017
| @@ -670,9 +678,9 @@ func (cc *ClientConn) handleResolvedAddrs(addrs []resolver.Address, err error) { | |||
|
|
|||
| cc.curAddresses = addrs | |||
|
|
|||
Contributor
Author
There was a problem hiding this comment.
@dfawley I updated the following if else while doing a rebase. Please take another look. Thanks!
service config will not override dial option balancer fix comments Add const roundrobin.Name and PickFirstBalancerName. remove WithBalancerBuilder fix tests delete withBalancerBuilder
343e6c5 to
e488e4c
Compare
And make WithBalancerName panic if no balancer is registered
dfawley
approved these changes
Dec 15, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WithBalancerName dial option specifies the name of the balancer to be used by the ClientConn. Service config updates can NOT override the balancer option.
#1694
This change is