Conversation
| # For proto payload, only the client should get the config. | ||
| scenario['client_config']['payload_config'] = EMPTY_PROTO_PAYLOAD | ||
| scenario['client_config']['payload_config'] = _payload_type(use_generic_payload, req_size, resp_size) | ||
| scenario['server_config']['payload_config'] = _payload_type(use_generic_payload, req_size, resp_size) |
There was a problem hiding this comment.
I think the problem here is that payload_config should only be set for client for non-generic server. The reason is that the non-generic server (Async and Sync) are supposed to respond with a message size that corresponds to what is requested in SimpleRequest (which is constructed based on client's payload config).
Setting payload config for a server should be illegal (and so C# qps worker is asserting that it is only set for generic server), which is what's breaking C# benchmarks (#9587).
https://github.com/grpc/grpc/blob/master/src/proto/grpc/testing/messages.proto#L76
grpc/src/proto/grpc/testing/control.proto
Line 143 in 2e096b0
grpc/test/cpp/qps/server_async.cc
Line 366 in f9b8730
|
Two problems with this PR:
|
No description provided.