Skip to content

Better qps_json_driver message when QPS_WORKERS env is missing#9184

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:qps_driver_cmdline
Dec 22, 2016
Merged

Better qps_json_driver message when QPS_WORKERS env is missing#9184
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:qps_driver_cmdline

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

Fixes #8749 (doesn't get rid of the QPS_WORKERS env variable, but provides sufficient guidance when variable is not set).

Copy link
Copy Markdown
Contributor

@vjpai vjpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 22, 2016

Known test failures:
#9124

@jtattermusch jtattermusch merged commit d7c923d into grpc:master Dec 22, 2016
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants