Add Python Client to Test Negative HTTP2 Conditions#9097
Add Python Client to Test Negative HTTP2 Conditions#9097ncteisen merged 1 commit intogrpc:masterfrom
Conversation
|
Cool! Please prepend a leading underscore on the file name. Does this test need to be recorded in |
f172649 to
d1ee2a3
Compare
|
Renamed the file. Although this file is more similar to interop/client.py than is is to the unit tests, I was wondering if maybe it should follow that convention instead? And at this point, no, it does not belong in tests.json since it cannot run as a standalone test. Eventually, we will do the same thing to is as was done to the interop tests, by making them into unit tests. |
|
You're absolutely right - the file should not have a leading underscore and should not be added to Please link in your commit log message to the document specifying these tests? I expect it would be a sibling of the interop test specifications? |
|
The documentation is in progress. Will link to it and update this thread when it is finished. |
|
|
||
| # common requests | ||
| _SMALL_SIZE = 1024 | ||
| _LARGE_SIZE = 314159 |
| _SMALL_SIZE = 1024 | ||
| _LARGE_SIZE = 314159 | ||
|
|
||
| _SMALL_SIMPLE_REQUEST = messages_pb2.SimpleRequest( |
There was a problem hiding this comment.
According to the doc https://github.com/ncteisen/grpc/blob/0eb69186f0b22f0e4bd5d6f1b4e31252bf614b76/doc/negative-http2-interop-test-descriptions.md, the request size is 271828.
|
|
||
| _SMALL_SIMPLE_REQUEST = messages_pb2.SimpleRequest( | ||
| response_type=messages_pb2.COMPRESSABLE, | ||
| response_size=_SMALL_SIZE, |
There was a problem hiding this comment.
According to the same doc the response_size should be _LARGE_SIZE. Can you please review the sizes to make sure they are in sync with the doc. Thanks!
fe77d28 to
02a7d42
Compare
Documentation for the new tests can be found https://github.com/grpc/grpc/blob/master/doc/negative-http2-interop-test-descriptions.md
|
Addressed all comments. Documentation is here. |
|
Almost all test are green. cloud_to_cloud:ruby:node_server:timeout_on_sleeping_server fails, but that is a well known flake (see #8989). Going to merge |
These tests are for the new Http/2 test server (#8900). They are designed to test client behavior when the server sends unexpected responses during rpcs.
cc @ericgribkoff @makdharma