Merged
Conversation
Setuptools was updated and our hacky namespace-package-chickens came back to roost. This removes the unsupported namespace package hacks.
nathanielmanistaatgoogle
suggested changes
Dec 13, 2016
src/python/grpcio/grpc/__init__.py
Outdated
| from grpc._cython import cygrpc as _cygrpc | ||
|
|
||
|
|
||
| ############################### Extension Shims ################################ |
Contributor
There was a problem hiding this comment.
If you say yes to my unhappily-late changes on master, they should be done here too.
61c3c54 to
f01c1b1
Compare
Uses dynamic loading to paper-over the negative effects of losing namespace packages in the previous commit.
f01c1b1 to
e136c1a
Compare
nathanielmanistaatgoogle
approved these changes
Dec 13, 2016
Contributor
nathanielmanistaatgoogle
left a comment
There was a problem hiding this comment.
Thanks!
Contributor
Author
|
Python tests are passing again. Will wait for master to finish passing Python tests, then merge both and upload 1.0.2. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #9071.
Failures: #9081, #9047, #9046