Skip to content

Advance objective c version to v1.0.2#8871

Merged
muxi merged 2 commits intogrpc:v1.0.xfrom
muxi:advance-objc-version-v102
Nov 29, 2016
Merged

Advance objective c version to v1.0.2#8871
muxi merged 2 commits intogrpc:v1.0.xfrom
muxi:advance-objc-version-v102

Conversation

@muxi
Copy link
Copy Markdown
Contributor

@muxi muxi commented Nov 28, 2016

To use Objective C only tag "objective-c-v1.0.2"

cc: @nicolasnoble @hsaliak

@jcanizales
Copy link
Copy Markdown
Contributor

Might the rest of the project ever want to release 1.0.2?

@muxi
Copy link
Copy Markdown
Contributor Author

muxi commented Nov 28, 2016

No, this is just an Objective C release

@muxi
Copy link
Copy Markdown
Contributor Author

muxi commented Nov 29, 2016

@jcanizales Ping :) Need it soon.

@jcanizales
Copy link
Copy Markdown
Contributor

This is just an Objective C release alright, but that doesn't answer my question :)

I'm trying to avoid the following scenario:

The rest of gRPC goes to 1.0.2 to fix some security bug four months from now. Now Objective-C can't update to the 1.0.2 version number because that number's already taken by this podspec. Mess.

@muxi
Copy link
Copy Markdown
Contributor Author

muxi commented Nov 29, 2016

From what I got from Kailash other languages go to v1.0.3 next.

@nicolasnoble can you confirm how it works?

@jcanizales
Copy link
Copy Markdown
Contributor

other languages go to v1.0.3 next

That'd solve my worry.

Copy link
Copy Markdown
Contributor

@jcanizales jcanizales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think about getting the actual version number from the common source, like the other languages, so it's much easier to be sure that it's been changed in all the necessary places.

@hsaliak
Copy link
Copy Markdown
Contributor

hsaliak commented Nov 29, 2016

re version bumps, http://semver.org/ does not dictate the steps of the increment, only that there must be increments, so all other languages can skip 1.0.2 and go to 1.0.3.. this is my understanding. Doing this reduces unnecessary churn for users of other languages since they do not have to deal with a NOOP version bump.

@muxi muxi merged commit 03cae8a into grpc:v1.0.x Nov 29, 2016
@muxi muxi deleted the advance-objc-version-v102 branch November 29, 2016 03:55
@lock lock bot locked as resolved and limited conversation to collaborators Jan 25, 2019
@lock lock bot unassigned makdharma Jan 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants