Ruby: show error class and message instead of unknown#8668

Merged

apolcyn merged 2 commits intogrpc:masterfrom

Dec 22, 2016

Contributor

lenage commented Nov 8, 2016

We need more info when an error raised, and unkown error handling call on server showing nothing useful. so in this PR, when you call gRPC service which implemented by ruby, it will show
error with below format to give you more information about error

"#{e.class}: #{e.message}"

I think we also need do this in other language, what do you think?

googlebot commented Nov 8, 2016

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

googlebot added the cla: no label

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

5 similar comments

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Contributor Author

lenage commented Nov 8, 2016

I signed it!

googlebot commented Nov 8, 2016

CLAs look good, thanks!

googlebot added cla: yes and removed cla: no labels

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

5 similar comments

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Collaborator

grpc-kokoro commented Nov 8, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

Member

murgatroid99 commented Nov 8, 2016

this is ok to test

lenage force-pushed the master branch from 988e372 to dad6aa3 Compare

November 9, 2016 06:01

Contributor Author

lenage commented Nov 9, 2016

@murgatroid99 seem like some check didn't pass, any suggestions to fix ?

Collaborator

grpc-kokoro commented Nov 14, 2016

Thanks for your pull request. The automated tests will run as soon as one of the admins verifies this change is ok for us to run on our infrastructure.

soltanmm-google assigned murgatroid99

murgatroid99 assigned apolcyn and unassigned murgatroid99

Contributor

apolcyn commented Dec 15, 2016

jenkins: test this please

apolcyn approved these changes

View reviewed changes

apolcyn mentioned this pull request

failure to build node interop docker image #9135

Closed

Contributor

apolcyn commented Dec 16, 2016

test failures on known issues:

re-running tests, to run the interop tests

Contributor

apolcyn commented Dec 16, 2016

jenkins: test this please

Contributor

apolcyn commented Dec 16, 2016

test failures again in:

interop PR failure to build node interop docker image #9135
interop PR build_docker_go failure #9011
linux PR linux/dbg: json_run_localhost timeout #9007
windows PR c_windows_dbg.vsprojects/Debug/h2_http_proxy_test.exe connectivity #9088

@lenage I think this is ok, but the interop build failures look somewhat unusual. Just to keep things minimal, can we please take out the changes to .gitignore?

Contributor Author

lenage commented Dec 22, 2016

@apolcyn of course, just take it out of .gitignore in last commit

Contributor Author

lenage commented Dec 22, 2016

@apolcyn seems like intero still can not get pass

lenage added 2 commits

December 22, 2016 16:01


          Ruby: show error class and message instead of unknown

9383d2b


          take tmp out of .gitignore file

2b60583

lenage force-pushed the master branch from cd55586 to 2b60583 Compare

December 22, 2016 08:02

Contributor Author

lenage commented Dec 22, 2016

Just sycn with upstream master branch, let' see what happens

apolcyn merged commit 7376d4b into grpc:master

Contributor

apolcyn commented Dec 22, 2016

all tests passed, LGTM

lock bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels