Format changes to python protoc generation#6479
Merged
jtattermusch merged 1 commit intogrpc:masterfrom May 12, 2016
Merged
Conversation
src/compiler/python_generator.cc
Outdated
Contributor
There was a problem hiding this comment.
Is this protobuf issue 888? If so, write it as TODO(https://github.com/google/protobuf/issues/888): Export....
Contributor
Author
|
Made suggested changes and fixed a bug. |
src/compiler/python_generator.cc
Outdated
Contributor
There was a problem hiding this comment.
Why change the indentation on this line?
Contributor
|
Please squash commits. |
c5938fc to
1b8f055
Compare
Contributor
Author
|
Made suggested changes. |
Contributor
|
luhguhtum. @soltanmm: any comment? |
src/compiler/python_generator.cc
Outdated
Contributor
There was a problem hiding this comment.
Style nit: C++ style has us use pointers for output parameters rather than lvalue references.
Contributor
There was a problem hiding this comment.
Yes, please don't use references for output parameters. It's fine to have const references though.
1b8f055 to
be187b0
Compare
Contributor
Author
|
Made suggested changes. |
Contributor
|
lgtm; waiting on tests |
Contributor
Author
|
test this please |
This was referenced May 16, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses #2481, #6413, #3867, #5107.
Note that ideally we wouldn't have to duplicate ModuleAlias from the protoc code, but we are already duplicating ModuleName, so I think we push that off to a separate PR.
These changes pass the new rigorous tests.