Skip to content

Prefer language rules#41304

Closed
mering wants to merge 14 commits into
grpc:masterfrom
mering:prefer-language-rules
Closed

Prefer language rules#41304
mering wants to merge 14 commits into
grpc:masterfrom
mering:prefer-language-rules

Conversation

@mering

@mering mering commented Dec 24, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

The native rules are disabled by default in Bazel 9 via --incompatible_autoload_externally= (empty list).

@mering mering force-pushed the prefer-language-rules branch from db80e95 to b8d4208 Compare December 24, 2025 09:45
@mering mering mentioned this pull request Dec 24, 2025
Merged
@yuanweiz yuanweiz self-requested a review December 26, 2025 21:36
yuanweiz
yuanweiz approved these changes Dec 26, 2025
View reviewed changes

@yuanweiz yuanweiz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change :)

@markdroth markdroth added release notes: no Indicates if PR should not be in release notes kokoro:run labels Dec 29, 2025
@markdroth

markdroth commented Dec 29, 2025

Copy link
Copy Markdown
Member

Looks like this is failing CI. Example failure: https://btx.cloud.google.com/invocations/153091c4-098e-4187-a7a8-9881efa6058f/log

Relevant lines:

ERROR: /tmpfs/altsrc/github/grpc/bazel/grpc_build_system.bzl:40:43: syntax error at 'sh_binary': expected ,
ERROR: /tmpfs/altsrc/github/grpc/bazel/grpc_build_system.bzl:40:52: unclosed string literal
ERROR: /tmpfs/altsrc/github/grpc/bazel/grpc_build_system.bzl:41:48: unclosed string literal
ERROR: /tmpfs/altsrc/github/grpc/bazel/grpc_build_system.bzl:41:49: load statement defines ')' more than once

@yuanweiz yuanweiz force-pushed the prefer-language-rules branch from b8d4208 to 60ff9be Compare January 7, 2026 19:52
@yuanweiz

yuanweiz commented Jan 7, 2026

Copy link
Copy Markdown
Contributor

fixed the unclosed quote and force-pushed.

@mering

mering commented Jan 8, 2026

Copy link
Copy Markdown
Contributor Author

fixed the unclosed quote and force-pushed.

Thanks for the fix!

@yuanweiz yuanweiz force-pushed the prefer-language-rules branch from 60ff9be to 085643d Compare January 8, 2026 20:13
@yuanweiz yuanweiz force-pushed the prefer-language-rules branch from 6676132 to 085643d Compare January 8, 2026 20:27
@yuanweiz yuanweiz mentioned this pull request Jan 30, 2026
Closed
@mateusz-olczyk mateusz-olczyk mentioned this pull request Feb 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuanweiz yuanweiz yuanweiz approved these changes

Assignees

@yuanweiz yuanweiz

Labels

bloat/none lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mering @markdroth @yuanweiz @grpc-kokoro