ObjC: Update Sample#4108
Conversation
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
There was a problem hiding this comment.
I was unsure whether to change this one. There is no protoc binary at that path for me. I couldn't find a built protoc binary after running make in the root of the project or in the third_party/protobuf directory.
There was a problem hiding this comment.
Yeah, sorry for that :-/ This file evolved to be used exclusively by the automatic tests (running ./tools/run_tests/run_tests.py -l objc from the root of the repo). Those will make plugins and set $CONFIG before doing pod install, making the podspec work.
As it became inappropriate for a sample, I added a version of it that just uses the installed protoc + plugin inside the examples directory. The Podfile of this sample should just point to that one (as the Podfile for the SwiftSample does). And ideally we should move generated_libraries/RemoteTestClient/* into tests/RemoteTestClient/* to eliminate confusion. (And also eliminate generated_libraries/RouteGuideClient, which isn't used anymore.)
Do you want to do that? Otherwise I'm happy to send a PR to your branch with the changes.
There was a problem hiding this comment.
The Podfile of this sample should just point to that one (as the Podfile for the SwiftSample does).
I can do this!
And ideally we should move generated_libraries/RemoteTestClient/* into tests/RemoteTestClient/* to eliminate confusion. (And also eliminate generated_libraries/RouteGuideClient, which isn't used anymore.)
I can send this over in a separate PR. Sound good?
|
Hi Benny! Thanks for this, it's awesome that you just went ahead and fixed it :) |
|
The changes in |
|
@jcanizales Ok - above issues addressed! |
* Reference discussion: grpc#4108 (diff)
|
Excellent; thanks again! |
|
@jcanizales as a separate discussion, what's the priority getting Swift support to work? I'm having a really hard time getting the Swift sample to run. For any meaningful Swift project that uses Cocoapods and ObjC dependencies, you need to use (No need to reply – I imagine you're very busy!) |
|
Ah, tricky! Let me open a separate issue and track it there. |
|
WRT priorities, I would say:
|
Addresses #3371
ProtoMethodinstead of the missingGRPCMethodNamePoints theRemoteTestpodspec to use the new path for thegrpc_objective_c_pluginplugin