Skip to content

[Python] Change Protobuf requirement to a fixed version in grpcio_tools#37666

Open
XuanWang-Amos wants to merge 2 commits intogrpc:masterfrom
XuanWang-Amos:fix_grpc_tools_req
Open

[Python] Change Protobuf requirement to a fixed version in grpcio_tools#37666
XuanWang-Amos wants to merge 2 commits intogrpc:masterfrom
XuanWang-Amos:fix_grpc_tools_req

Conversation

@XuanWang-Amos
Copy link
Copy Markdown
Contributor

@XuanWang-Amos XuanWang-Amos commented Sep 10, 2024

Fix: #37609

@XuanWang-Amos XuanWang-Amos added the release notes: no Indicates if PR should not be in release notes label Sep 10, 2024
@XuanWang-Amos XuanWang-Amos marked this pull request as ready for review September 10, 2024 18:11
@XuanWang-Amos
Copy link
Copy Markdown
Contributor Author

After discussing, we don't think this PR is the right fix because:

  • Compatibility Guarantee: The Protobuf team has assured us of compatibility between generated code and a range of Protobuf runtime versions. Code generated by a particular version of grpcio-tools should work with the range of Protobuf runtimes listed in requirement.
  • Diamond Dependency Risk: Fixing the requirement to a single version increases the likelihood of introducing diamond dependency conflicts, particularly with our dynamic stub functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UserWarnings emitted from all protoc-generated _pb2 packages

4 participants