[dns] unskip c-ares tests on arm#34232
Merged
apolcyn merged 2 commits intogrpc:masterfrom Sep 18, 2023
Merged
Conversation
jtattermusch
approved these changes
Sep 4, 2023
Contributor
jtattermusch
left a comment
There was a problem hiding this comment.
LGTM as long as the test reliably passes.
|
i like it |
|
**** |
Contributor
|
Can this be merged? |
Contributor
Author
|
Thanks for the ping, I was able to see that tests pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that we have #33942 (and another follow-up fix), I think the issue from #25289 is likely fixed