Skip to content

[Build] Shared builds on windows #34103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
veblush merged 16 commits into from
Sep 12, 2023
Merged

[Build] Shared builds on windows #34103

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
7aae15c
add {GPR,GRPC,GRPCXX}_DLL mechanism for missing symbols on windows
isuruf Oct 22, 2022
08ea663
fix support_enabled for windows
isuruf Oct 22, 2022
9b5e350
Fix `data with thread storage duration may not have dll interface`
h-vetinari May 8, 2023
c0f7a0e
put some grpc::experimental classes needed by arrow in DLL
h-vetinari Jun 9, 2023
b1936f8
link grpc++_unsecure to grpc++
h-vetinari Jun 9, 2023
feff474
add GRPC_DLL to slice_refcount to fix link error
dawidcha Aug 14, 2023
71835f9
Resolve upb-generated symbols by duplicating code where necessary
dawidcha Aug 15, 2023
15d6200
Normalize macro names and add docs
dawidcha Aug 15, 2023
cf13b4e
Fix to port_platform for XXX_DLL defs, CMakeLists improvements, fix t…
dawidcha Aug 17, 2023
b05c631
CMakeLists.txt template and generated output
dawidcha Aug 17, 2023
9331a5e
Build fixes following rebase
dawidcha Aug 20, 2023
e5094c1
Fix CMakeLists.txt.template
dawidcha Aug 24, 2023
19cf0c7
Standardize code formatting
dawidcha Aug 25, 2023
62d2eaf
Revert all non-Windows DLL builds back to previous code
dawidcha Aug 30, 2023
380f65d
No need for scope qualifier
dawidcha Aug 30, 2023
4c98a9b
Disable grpc++_unsecure build for DLLs (and remove duplicate source h…
dawidcha Sep 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
101 changes: 97 additions & 4 deletions CMakeLists.txt
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions include/grpc/event_engine/event_engine.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ class EventEngine : public std::enable_shared_from_this<EventEngine> {
/// \a Cancel method.
struct TaskHandle {
intptr_t keys[2];
static const TaskHandle kInvalid;
static const GRPC_DLL TaskHandle kInvalid;
friend bool operator==(const TaskHandle& lhs, const TaskHandle& rhs);
friend bool operator!=(const TaskHandle& lhs, const TaskHandle& rhs);
};
Expand All @@ -131,7 +131,7 @@ class EventEngine : public std::enable_shared_from_this<EventEngine> {
/// Returned by \a Connect, and can be passed to \a CancelConnect.
struct ConnectionHandle {
intptr_t keys[2];
static const ConnectionHandle kInvalid;
static const GRPC_DLL ConnectionHandle kInvalid;
friend bool operator==(const ConnectionHandle& lhs,
const ConnectionHandle& rhs);
friend bool operator!=(const ConnectionHandle& lhs,
Expand Down
Loading