Skip to content

Backport: Ensure compatibility with the new custom kokoro win2019 image (#32649) to 1.53.x#32660

Merged
jtattermusch merged 1 commit intogrpc:v1.53.xfrom
jtattermusch:backport_32649_1_53
Mar 21, 2023
Merged

Backport: Ensure compatibility with the new custom kokoro win2019 image (#32649) to 1.53.x#32660
jtattermusch merged 1 commit intogrpc:v1.53.xfrom
jtattermusch:backport_32649_1_53

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

Backports #32649.

…2649)

Fix incompatibilities identified when running adhoc runs on the new
custom win2019 image.
After merging this, it should be possible to switch to the new image
without breaking any tests.

- for most fixes I added a comment that explains why they're necessary.
- the new image won't have VS2015 installed, so I'm switching the protoc
artifact build to VS2017

This PR will need to be backported to older release branches to ensure
the windows tests continue working on those branches as well (IMHO I
haven't made any changes that would be difficult to backport and I tried
to keeps the diff as small as possible to avoid issues when
backporting).

After we switch to the new image (and all the windows tests are green),
we can incrementally move the builds that are still using VS2017 to
VS2019.
@jtattermusch jtattermusch merged commit 6e1ebe7 into grpc:v1.53.x Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants