Build Target Reorganization Part 1#30518
Merged
ralphchung merged 10 commits intogrpc:masterfrom Aug 11, 2022
Merged
Conversation
ctiller
reviewed
Aug 7, 2022
BUILD
Outdated
| tags = ["nofixdeps"], | ||
| visibility = ["@grpc:alt_gpr_base_legacy"], | ||
| tags = [ | ||
| "avoid_dep", |
Member
There was a problem hiding this comment.
Suspect we should remove the avoid_dep here... could you try and see whether fix_build_deps stays rational?
Contributor
Author
There was a problem hiding this comment.
I tried, and I did not find anything change because of this tag.
ctiller
approved these changes
Aug 7, 2022
Member
ctiller
left a comment
There was a problem hiding this comment.
Please do a trial import and see if there's any problems there before submitting.
Vignesh2208
approved these changes
Aug 8, 2022
Contributor
Vignesh2208
left a comment
There was a problem hiding this comment.
If the goal is to eliminate gpr_base entirely, that will most definitely require a cherrypick since gpr_base is used in some places internally as well. Please confirm! Thanks!
6fe0eb2 to
653c295
Compare
ctiller
approved these changes
Aug 10, 2022
a43239a to
6a6b0c5
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that we are removing codegen related files, we need to clean up the build targets in the current build file. There will be a series of PRs for this.
The new build targets should roughly follow this dependency graph.
Detailed steps is the following.
gpr_baseis merged intogpr. Thegprhere itself is nothing but depending ongpr_base. I don't think we need to separate them.grpc++_internalsandgrpc++_internal_hdrs_onlyare merged intogrpc++. The reason is similar.grpc++does not contain much stuff butgrpc++_internals.gpr_codegenis merged togprsince the files ingpr_codegenshould be removed in the future and be moved togpr.grpc_codegenis merged togrpc_basewith the similar reason as above.grpc++_codegen_baseandgrpc++_codegen_base_srcare merged togrpc++_basewith the similar reason as above.grpc_secureis merged togrpcsincegrpcis by default secure. We do not need to separate them.grpc++_base_unsecureis merged either intogrpc++_baseor intogrpc++_unsecure.This PR removes
gpr_baseand mergesgpr_codegenintogprwithout removinggpr_codegenfor temporary compatibility. It should be removed in the following PRs.