xds-k8s jobs: standardize TESTING_VERSION (1.40.x backport)#30056
Merged
ejona86 merged 1 commit intogrpc:v1.40.xfrom Jun 21, 2022
Merged
xds-k8s jobs: standardize TESTING_VERSION (1.40.x backport)#30056ejona86 merged 1 commit intogrpc:v1.40.xfrom
ejona86 merged 1 commit intogrpc:v1.40.xfrom
Conversation
This Addresses the issue with skips not working in golang tests, ref b/235688697. 1. Unifies `TESTING_VERSION` detection in grpc_xds_k8s_install_test_driver.sh - new approach applicable to all languages. 2. Use `TESTING_VERSION` in all build files in `--testing_version` and when tagging docker images. This will be backported to all active test branches. Build Scripts in all other languages will be updated as well.
gnossen
approved these changes
Jun 17, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Addresses the issue with skips not working in golang tests, ref b/235688697.
TESTING_VERSIONdetection in grpc_xds_k8s_install_test_driver.sh - new approach applicable to all languages.TESTING_VERSIONin all build files in--testing_versionand when tagging docker images. This will be backported to all active test branches. Build Scripts in all other languages will be updated as well.Backport of #30027