Skip unittest.grpc.io dualstack socket test if DNS64 servers are used#28343
Merged
jtattermusch merged 1 commit intogrpc:masterfrom Dec 13, 2021
Merged
Skip unittest.grpc.io dualstack socket test if DNS64 servers are used#28343jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch merged 1 commit intogrpc:masterfrom
Conversation
Contributor
Author
|
CC @apolcyn |
Contributor
Author
|
Adhoc runs on macsvc-mojave pool: |
veblush
approved these changes
Dec 13, 2021
Contributor
Author
|
Known failures:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We want to migrate C++ test jobs to kokoro macservice worker, but currently the dualstack_socket_test is failing there.
See b/201064791
The issue is that macservice workers are using DNS64 name servers, and when resolving
loopback4.unittest.grpc.io, it gives a correct, but unexpected result forloopback4.unittest.grpc.io has IPv6 address 64:ff9b::7f00:1(it's a IPv4 address wrapped in IPv6 - which is something that's currently not supported by dualstack_socket_test)The workaround is to detect whether DNS64 servers are used (they will be on kokoro macservice workers) and skip the "*.unittest.grpc.io" tests if so.