Skip to content

Skip unittest.grpc.io dualstack socket test if DNS64 servers are used#28343

Merged
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:dns64_dualstack_fix
Dec 13, 2021
Merged

Skip unittest.grpc.io dualstack socket test if DNS64 servers are used#28343
jtattermusch merged 1 commit intogrpc:masterfrom
jtattermusch:dns64_dualstack_fix

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

We want to migrate C++ test jobs to kokoro macservice worker, but currently the dualstack_socket_test is failing there.
See b/201064791

The issue is that macservice workers are using DNS64 name servers, and when resolving loopback4.unittest.grpc.io, it gives a correct, but unexpected result for loopback4.unittest.grpc.io has IPv6 address 64:ff9b::7f00:1 (it's a IPv4 address wrapped in IPv6 - which is something that's currently not supported by dualstack_socket_test)

$host loopback4.unittest.grpc.io 2001:4860:4860::6464
Using domain server:
Name: 2001:4860:4860::6464
Address: 2001:4860:4860::6464#53
Aliases:

loopback4.unittest.grpc.io has address 127.0.0.1
loopback4.unittest.grpc.io has IPv6 address 64:ff9b::7f00:1

The workaround is to detect whether DNS64 servers are used (they will be on kokoro macservice workers) and skip the "*.unittest.grpc.io" tests if so.

@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Dec 13, 2021
@jtattermusch jtattermusch requested a review from veblush December 13, 2021 12:30
@jtattermusch
Copy link
Copy Markdown
Contributor Author

CC @apolcyn

@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 13, 2021

@jtattermusch
Copy link
Copy Markdown
Contributor Author

Known failures:

  • macos artifacts is b/209603283

@jtattermusch jtattermusch merged commit 5466a0b into grpc:master Dec 13, 2021
@copybara-service copybara-service bot added the imported Specifies if the PR has been imported to the internal repository label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bloat/none imported Specifies if the PR has been imported to the internal repository lang/core perf-change/none release notes: no Indicates if PR should not be in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants