testing: add a fake TCP and UDP server to test/core/util (extracted from #27883)#28332
Merged
apolcyn merged 4 commits intogrpc:masterfrom Dec 14, 2021
Merged
testing: add a fake TCP and UDP server to test/core/util (extracted from #27883)#28332apolcyn merged 4 commits intogrpc:masterfrom
apolcyn merged 4 commits intogrpc:masterfrom
Conversation
Member
|
Given #27595 removed our UDP code, is having a UDP fake still useful? |
Contributor
Author
Yeah, the UDP fake is still used in some DNS resolver tests (mainly to act as a non-responsive DNS server). |
markdroth
approved these changes
Dec 14, 2021
Member
markdroth
left a comment
There was a problem hiding this comment.
Reviewed 10 of 13 files at r1, 3 of 3 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @apolcyn)
Contributor
Author
|
python windows: #25124 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is extracted from #27883, since it's a mostly independent change from the rest of #27883.
This change merges the fake servers implemented separately in
alts_concurrrent_connectivity_test.ccand the fake UDP server intest/cpp/naming/dns_test_util.hinto a single fake that lives in test/core/util.