Skip to content

Pin rake-compiler at 1.1.1 to fix ruby breakages on CI#28320

Closed
jtattermusch wants to merge 2 commits intogrpc:masterfrom
jtattermusch:pin_rake_compiler
Closed

Pin rake-compiler at 1.1.1 to fix ruby breakages on CI#28320
jtattermusch wants to merge 2 commits intogrpc:masterfrom
jtattermusch:pin_rake_compiler

Conversation

@jtattermusch
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch commented Dec 9, 2021 •
edited
Loading

These rake-compiler versions published on Dec 7 have probably caused b/209603283 (and 1.1.3 has fixed things partially, but not fully).

1.1.3 - December 07, 2021 (37.5 KB)
1.1.2 - December 07, 2021 (37.5 KB)

Example failure:
https://source.cloud.google.com/results/invocations/02d5523f-14f8-444e-98ba-8b90e3a1cabe (with rake-compiler 1.1.3)

@jtattermusch jtattermusch added the release notes: no Indicates if PR should not be in release notes label Dec 9, 2021
@jtattermusch jtattermusch requested a review from apolcyn December 9, 2021 09:21
@jtattermusch jtattermusch changed the title Pin rake-compiler at 1.1.1 to fix ruby breakages. Pin rake-compiler at 1.1.1 to fix ruby breakages on CI Dec 9, 2021
@jtattermusch jtattermusch mentioned this pull request Dec 9, 2021
Merged
@jtattermusch
Copy link
Copy Markdown
Contributor Author

jtattermusch commented Dec 9, 2021 •
edited
Loading

On linux, the ruby artifacts are now building correctly.

But macos artifact build failure seems weird:

+ rake gem:native
Invalid gemspec in [/Users/kbuilder/.rvm/gems/ruby-2.5.0/specifications/bundler-1.17.3.gemspec]: /Users/kbuilder/.rvm/gems/ruby-2.5.0/specifications/bundler-1.17.3.gemspec:47: syntax error, unexpected keyword_end, expecting end-of-input
    end
    ^~~
Invalid gemspec in [/Users/kbuilder/.rvm/gems/ruby-2.5.0/specifications/bundler-1.17.3.gemspec]: /Users/kbuilder/.rvm/gems/ruby-2.5.0/specifications/bundler-1.17.3.gemspec:47: syntax error, unexpected keyword_end, expecting end-of-input
    end
    ^~~
rake aborted!

https://source.cloud.google.com/results/invocations/515963d9-596e-4498-a5cf-e0632870f538/targets/github%2Fgrpc/tests

apolcyn
apolcyn approved these changes Dec 9, 2021
View reviewed changes
templates/grpc.gemspec.template
s.add_development_dependency 'rake', '~> 13.0'
s.add_development_dependency 'rake-compiler', '~> 1.1'
# rake-compiler 1.1.2 and 1.1.3 are broken, see b/209603283
s.add_development_dependency 'rake-compiler', '1.1.1'
Copy link
Copy Markdown
Contributor

@apolcyn apolcyn Dec 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we try making this '<= 1.1.1' ?

I think that might fix the macos artifacts build issue

@apolcyn apolcyn mentioned this pull request Dec 9, 2021
Merged
@apolcyn
Copy link
Copy Markdown
Contributor

apolcyn commented Dec 10, 2021

#28328 was merged instead of this one (though it's functionally the same)

@apolcyn apolcyn closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@apolcyn apolcyn apolcyn approved these changes

Assignees

@apolcyn apolcyn

Labels

lang/ruby release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jtattermusch @apolcyn