[Backport] Reduce the workload of presubmit artifact builds and distribtests#28289
Closed
lidizheng wants to merge 2 commits intogrpc:v1.43.xfrom
Closed
[Backport] Reduce the workload of presubmit artifact builds and distribtests#28289lidizheng wants to merge 2 commits intogrpc:v1.43.xfrom
lidizheng wants to merge 2 commits intogrpc:v1.43.xfrom
Conversation
…pc#28228) * Reduce the workload of presubmit artifact builds and distribtests * Create and redirect Kokoro config * Remove duplicated scripts and use env var config * Clean-up Kokoro cfg * [DO-NOT-SUBMIT] Add ad-hoc TASK_RUNNER_EXTRA_FILTERS * Revert "[DO-NOT-SUBMIT] Add ad-hoc TASK_RUNNER_EXTRA_FILTERS" This reverts commit 9436ac5.
jtattermusch
approved these changes
Dec 7, 2021
Contributor
There was a problem hiding this comment.
Fair enough, but I'd be more in favor of backporting just the duplication of the master/*.cfg files to pull_request/*.cfg.
There is no reason to introduce extra complexity to an already-cut branch (and increase the risk of breaking stuff on release branch where we should do as few changes as possible). And you might need to backport to older release branches at some point as well, at which point backporting the entire PR or nontrivial complexity might be problematic.
Leaving the final resolution up to you.
Contributor
|
Let's merge #28298 instead. |
Contributor
Author
|
Thanks for creating a thiner version of this PR. It's nice to be cautious. Closing this PR for #28298. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #28228