Fix conflicts with msvc arm neon64 intrinsics to enable win/arm64#28164
Merged
markdroth merged 1 commit intogrpc:masterfrom Nov 29, 2021
Merged
Fix conflicts with msvc arm neon64 intrinsics to enable win/arm64#28164markdroth merged 1 commit intogrpc:masterfrom
markdroth merged 1 commit intogrpc:masterfrom
Conversation
|
|
Contributor
Author
|
@markdroth Can you help with the review please? |
Member
|
This looks reasonable. I've triggered the tests. |
markdroth
approved these changes
Nov 29, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch rename
move64private function fromtransport.ccto avoid conflicts with MSVC arm64 neon intrinsic function. See arm64 definition heregrpccannot be build for windows on arm64 devices without this patch.@markdroth