Use default port 443 in HTTP CONNECT request#26331
Merged
Merged
Conversation
markdroth
approved these changes
May 24, 2021
| absl::string_view port; | ||
| SplitHostPort(target, &host, &port); | ||
| if (port.empty()) { | ||
| return JoinHostPort(host, 443); |
Member
There was a problem hiding this comment.
I'd ideally prefer not to hard-code the default this way, independently of the default in the DNS resolver that specifies the same thing. But unfortunately, I don't have a better suggestion for how to handle this, so I guess we can live with it.
Member
Author
There was a problem hiding this comment.
I can make it a constant. Something like kDefaultSecurePort that is shared between the resolver and this.
Member
There was a problem hiding this comment.
That sounds fine. It's already defined independently in both of the DNS resolver implementations:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #26227