Skip to content

Fix-forward "Added portability test with openssl 1.0.2"#25860

Merged
veblush merged 1 commit intomasterfrom
revert-25812-revert-25770-ssl-test
Jun 15, 2021
Merged

Fix-forward "Added portability test with openssl 1.0.2"#25860
veblush merged 1 commit intomasterfrom
revert-25812-revert-25770-ssl-test

Conversation

@veblush
Copy link
Copy Markdown
Contributor

@veblush veblush commented Apr 1, 2021 •
edited
Loading

Fix foward #25770
Reverts #25812

Fixes #24960

@veblush veblush added release notes: no Indicates if PR should not be in release notes lang/core area/test labels Apr 1, 2021
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Apr 1, 2021 •
edited
Loading

grpc/core/master/linux/grpc_portability: failed

@veblush veblush force-pushed the revert-25812-revert-25770-ssl-test branch from 72e3bf0 to a105c8c Compare June 3, 2021 22:43
@matthewstevenson88 matthewstevenson88 mentioned this pull request Jun 8, 2021
Closed
@veblush veblush force-pushed the revert-25812-revert-25770-ssl-test branch from a105c8c to cc8f129 Compare June 8, 2021 17:58
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Jun 8, 2021 •
edited
Loading

grpc/core/master/linux/grpc_portability: aborted

@veblush veblush marked this pull request as ready for review June 8, 2021 18:00
@matthewstevenson88
Copy link
Copy Markdown
Contributor

matthewstevenson88 commented Jun 9, 2021

Seems like the portability test ran into a DEADLINE_EXCEEDED error - could we try re-running it?

While we're at it, could we rerun the presubmit checks to make sure that the Artifact Build MacOS and Basic Tests Python Windows failures are unrelated flakes? (That seems to be the case from looking at logs.)

@veblush veblush force-pushed the revert-25812-revert-25770-ssl-test branch from cc8f129 to 2c01c7c Compare June 9, 2021 20:14
@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Jun 9, 2021 •
edited
Loading

Yeah, it didn't manage to get a change to run the test due to timeout in the queue. Let's rerun the test.
linux/grpc_portability: failed

@matthewstevenson88
Copy link
Copy Markdown
Contributor

matthewstevenson88 commented Jun 9, 2021

Looks like the portability test failed in the same way again - should we just keep re-running it until it passes?

jtattermusch
jtattermusch approved these changes Jun 10, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@jtattermusch jtattermusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Jun 15, 2021 •
edited
Loading

It seems that it's hard to trigger grpc_portability manually only for this PR. One more try

prod:grpc/core/master/linux/grpc_portability: passed

matthewstevenson88
matthewstevenson88 approved these changes Jun 15, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@matthewstevenson88 matthewstevenson88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we're not able to run the portability test without merging the PR, that won't be the end of the world, since we're just adding a new test and not modifying existing ones.

@veblush
Copy link
Copy Markdown
Contributor Author

veblush commented Jun 15, 2021

Wow finally it passed! It's all set to get merged!

@veblush veblush merged commit 83681f2 into master Jun 15, 2021
@stanley-cheung stanley-cheung deleted the revert-25812-revert-25770-ssl-test branch November 16, 2021 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@matthewstevenson88 matthewstevenson88 matthewstevenson88 approved these changes

@apolcyn apolcyn Awaiting requested review from apolcyn

@nicolasnoble nicolasnoble Awaiting requested review from nicolasnoble

+1 more reviewer

@jtattermusch jtattermusch jtattermusch approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/test lang/core release notes: no Indicates if PR should not be in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Adding a test with openssl or variants without TLS v1.3 support

3 participants

@veblush @matthewstevenson88 @jtattermusch